Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing license file in the libcramjam crate #120

Merged

Conversation

musicinmybrain
Copy link
Contributor

This PR adds a symbolic link to the top-level LICENSE file in libcramjam/, which ensures that a license file appears in the published crate as required by the chosen MIT license terms.

Before this PR:

gh repo clone milesgranger/cramjam
cd cramjam/libcramjam
git checkout add-c-api
cargo publish --dry-run
tar -tzvf ../target/package/libcramjam-0.1.5.crate

(no license file appears in the output)

After this PR:

[…]
-rw-r--r-- 0/0            1070 2006-07-23 21:21 libcramjam-0.1.5/LICENSE
[…]

Note that the symbolic link is resolved by cargo publish, and a regular file appears in the crate.

Copy link
Owner

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you. 👍

@milesgranger milesgranger merged commit d96826f into milesgranger:add-c-api Jan 6, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants